From: Florian Müllner <fmuellner@gnome.org>
Date: Tue, 27 Oct 2020 00:03:43 +0000 (+0100)
Subject: messageTray: Don't play sound when banners are disabled
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~616^2^2~769
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=709c226fc3f48e6a3f5175a49b09e15bdc2dc05b;p=gnome-shell.git

messageTray: Don't play sound when banners are disabled

When support for notification sounds was added, it made some sense
to keep the 'enable-sound' setting independent from 'show-banners'.

However that changed when 'show-banners' was rebranded in the UI as
"Do Not Disturb", as sounds are at least as disturbing as the banners.

https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/2873
---

diff --git a/js/ui/messageTray.js b/js/ui/messageTray.js
index d89af2b83..7aac503ec 100644
--- a/js/ui/messageTray.js
+++ b/js/ui/messageTray.js
@@ -784,8 +784,6 @@ var Source = GObject.registerClass({
 
         if (this.policy.showBanners || notification.urgency == Urgency.CRITICAL)
             this.emit('notification-show', notification);
-        else
-            notification.playSound();
     }
 
     notify(propName) {